[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 11 14:52:59 PDT 2022


kastiglione added a comment.

@JDevlieghere I had it as `dump pcm` at first, but switched it to `pcm-info` for two reasons

1. it doesn't dump the whole pcm, the actual ast itself is not dumped
2. to match the clang flag `-module-file-info`

I agree that `pcm` is better, but I was worried it would be misunderstood as dumping more than it actually does.

I think -info here is more like -metadata but shorter.

One option is to name it back to `pcm`, and update the help description to be more descriptive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129456/new/

https://reviews.llvm.org/D129456



More information about the lldb-commits mailing list