[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Thu Jun 30 03:08:05 PDT 2022

labath added a comment.

In D128250#3598291 <https://reviews.llvm.org/D128250#3598291>, @Emmmer wrote:

> In D128250#3598223 <https://reviews.llvm.org/D128250#3598223>, @DavidSpickett wrote:
>
>> I'll give this a more thorough read later just one comment for now.
>>
>> In the meantime, what's your plan for testing this config going forward? This patch would be fine as the first of a series but I'd like to see the follow ups that make it usable.
>>
>> Will there be a build bot? You could at least enable building lldb on an existing riscv bot, while you iron out all the inevitable test suite issues.
>
> To use gdbserver by lldb requires the participation of lldb-server, so my current plan is to allow lldb to co-op with gdbserver, then let lldb be able to use lldb-server, pass the unit tests, and finally add riscv32 support.

We do have a separate test suite just for lldb-server, so you might be able to use that to gauge your progress without worrying about the lldb side too much.

I wouldn't say that the presence of a buildbot is an absolute requirement to get this off the ground, but I would strongly recommend setting up one, even if it's just building for now. We don't e.g. have a bot for SystemZ, and the overall effect of that is that nobody knows whether SystemZ debugging actually works.

================
Comment at: lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.cpp:1
+//
+// Created by emmmer on 6/22/22.
----------------
same here

================
Comment at: lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.h:1
+//
+// Created by emmmer on 6/22/22.
----------------
Please use the standard llvm header with licence info and stuff.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128250/new/

https://reviews.llvm.org/D128250