[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

Fri Jul 1 06:49:12 PDT 2022

labath added a comment.

In D126983#3624901 <https://reviews.llvm.org/D126983#3624901>, @mgorny wrote:

> In D126983#3624800 <https://reviews.llvm.org/D126983#3624800>, @labath wrote:
>
>> Some flakyness here: https://lab.llvm.org/buildbot/#/builders/68/builds/35111/steps/6/logs/stdio
>
> That's so rare it's going to be hard figuring out if any changes actually fix it. My only idea is to either increase the sleep within `continue_and_get_threads_running()` or make output inside the process more frequent — though the latter probably won't help if some threads don't get run because of loaded system.

Don't we have the ability to wait for a specific output from the process? Could we make use of that to await for the actual "thread is running" message? If needed, we can put some barriers between the print calls, and then we can even make sure each thread prints its message exactly once.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126983/new/

https://reviews.llvm.org/D126983