[Lldb-commits] [PATCH] D128849: [lldb] [llgs] Send process output asynchronously in non-stop mode

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 30 01:25:55 PDT 2022


mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3931
 
+GDBRemoteCommunication::PacketResult GDBRemoteCommunicationServerLLGS::HandleNotificationAck(std::deque<std::string> &queue) {
+  // Per the protocol, the first message put into the queue is sent
----------------
labath wrote:
> this could use formatting
Yes, indeed. I've left it like this for clang-format, then forgotten to run it. Sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128849/new/

https://reviews.llvm.org/D128849



More information about the lldb-commits mailing list