[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D128069#3619736 <https://reviews.llvm.org/D128069#3619736>, @dmlary wrote:

> updated to include test cases for `SBSection.GetAlignment()` and `SBSection.alignment` property.

Cool. Looks good, just a couple of small comments inline.



================
Comment at: lldb/test/API/python_api/section/TestSectionAPI.py:45
+        exe = self.getBuildArtifact("aligned.out")
+        self.yaml2obj("aligned.yml", exe)
+        target = self.dbg.CreateTarget(exe)
----------------
we normally use the `.yaml` extension.


================
Comment at: lldb/test/API/python_api/section/TestSectionAPI.py:61
+        section = target.modules[0].sections[0]
+        self.assertEqual(section.alignment, 0x1000)
----------------
I don't think this is worth a separate test, I'd just move it next to the other check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128069/new/

https://reviews.llvm.org/D128069