[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

[Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3ec54c66075: [lldb] Fix unused variable warning in TraceHTR (NFC) (authored by kevcadieux, committed by Walter Erquinigo <wallace at fb.com>).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128874/new/

https://reviews.llvm.org/D128874

Files:
  lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp


Index: lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp
===================================================================
--- lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp
+++ lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp
@@ -132,6 +132,9 @@
   cursor.SetForwards(true);
   cursor.Seek(0, TraceCursor::SeekType::Beginning);
 
+  // TODO: fix after persona0220's patch on a new way to access instruction
+  // kinds
+  /*
   Target &target = thread.GetProcess()->GetTarget();
   auto function_name_from_load_address =
       [&](lldb::addr_t load_address) -> llvm::Optional<ConstString> {
@@ -146,8 +149,7 @@
       return llvm::None;
   };
 
-  /* TODO: fix after persona0220's patch on a new way to access instruction
-  kinds while (cursor.HasValue()) { if (cursor.IsError()) {
+  while (cursor.HasValue()) { if (cursor.IsError()) {
       // Append a load address of 0 for all instructions that an error occured
       // while decoding.
       // TODO: Make distinction between errors by storing the error messages.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128874.441255.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220630/5649f75f/attachment.bin>