[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

Wed Jun 29 20:48:56 PDT 2022

brooksmoses added a comment.

We're seeing a number of LLDB test failures from this change.  If I'm understanding correctly, that's working by design because we're building the test code with a version of LLVM that's from a revision that's not quite as recent as the LLDB code we're testing.

This seems like a substantial problem.  If I release this LLDB as my company's internal build, and one of my users wants to debug a failing application that happens to have been built before the corresponding internal LLVM release -- or they happen to build their application on a release branch pinned to an older LLVM build -- they won't have a working string data-formatter, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128694/new/

https://reviews.llvm.org/D128694