[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/fork_testbase.py:155
         parent_expect = [
-            "T05thread:p{}.{};.*".format(parent_pid, parent_tid),
+            "T13thread:p{}.{};.*".format(parent_pid, parent_tid),
             "W00;process:{}#.*".format(parent_pid),
----------------
labath wrote:
> SIGSTOP is 17 (0x11) on macos. Maybe you could check for "reason:signal" instead?
I don't think macos is really relevant but you're right. I've forgotten that we haven't changed lldb-server to use normalized signos. I'll fix all the tests not to rely on specific signos.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128780/new/

https://reviews.llvm.org/D128780