[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

Wed Jun 29 01:24:17 PDT 2022

labath added a comment.

In D128678#3616685 <https://reviews.llvm.org/D128678#3616685>, @mstorsjo wrote:

> Thanks, this looks more complete and consistent to me now!
>
> In D128678#3615531 <https://reviews.llvm.org/D128678#3615531>, @labath wrote:
>
>> It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?
>
> Well it does need being able to link executables for these targets, which you generally can't rely on I think? (I don't think the `%build` macro in general works as a cross compiler?)

What Omair said. And, generally speaking, I'm not convinced of the usefulness of the %build script. It lacked sufficient buy-in from the start is now pretty much exclusively used for windows tests. It supports both cross-compilation and host-compilation modes, but it's very inconsistent about which one it uses for a particular combination of flags and compilers.
Overall, I don't think we need any kind of scripts for cross-compilation -- we can just issue appropriate clang and lld commands ourselves. There /might/ be a use case for host-compilation, but I suspect that could also be achieved with more conventional means (a couple of well-placed substitutions).

In D128678#3616753 <https://reviews.llvm.org/D128678#3616753>, @omjavaid wrote:

> However its MS DIA SDK based PDB test which is only available on system windows. NATIVE PDB reader tests are already being run independently.

Ok, that makes sense. Thanks.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128678/new/

https://reviews.llvm.org/D128678