[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:38
+void TraceCursorIntelPT::Next() {
+  m_pos += IsForwards() ? 1 : -1;
 
----------------
jj10306 wrote:
> should only do this increment or decrement if `HasValue()` is true? otherwise (in theory) this value could wrap around if it's incremented/decremented too many times?
i think that's a very extreme case =P


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:40
 
+  {
+    // We try to go to a neighbor tsc range that might contain the current pos
----------------
jj10306 wrote:
> why is this new scope introduced here?
i'll remove it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128543/new/

https://reviews.llvm.org/D128543