[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

Thanks, this looks more complete and consistent to me now!

In D128678#3615531 <https://reviews.llvm.org/D128678#3615531>, @labath wrote:

> It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?

Well it does need being able to link executables for these targets, which you generally can't rely on I think? (I don't think the `%build` macro in general works as a cross compiler?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128678/new/

https://reviews.llvm.org/D128678