[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added inline comments.


================
Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:1
+REQUIRES: system-windows, lld, (target-arm || target-aarch64) 
+RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
----------------
mstorsjo wrote:
> Hmm, I wasn't aware of the fact that you can do such `||` expressions in the `REQUIRES` line - I presume you've verified that this test actually does get picked up and executed?
This is tested on both Arm/Windows and x86/Windows.


================
Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:2
+REQUIRES: system-windows, lld, (target-arm || target-aarch64) 
+RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
+RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s
----------------
mstorsjo wrote:
> Here, there's probably no need to force it to 32 bit mode - unless we expect to have a similar test for the undecorated mangling in aarch64 and x86_64 mode too?
Mangling is specific to x86 32 bit only. All other configs shouldnt do it. I guess we can test it for both 64bit and 32bit arm. Let me update my change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128678/new/

https://reviews.llvm.org/D128678