[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D128557#3609545 <https://reviews.llvm.org/D128557#3609545>, @JDevlieghere wrote:

> Thanks for pointing that out. I blindly copied the categories logic from `Log::Disable` which uses it when computing the flags. I've omitted it for now because I think it would be weird to set the circular buffer size to 5 and then have 0 messages printed for the process category because 5 log messages from the commands category pushed them out. One solution would be to keep a circular buffer per category. I'll think about it and if I come up with a good solution I'll put up another patch.

Sounds good. We would still want to keep a circular buffer and keep all messages in order in case they want to dump just a few of the total categories as those log messages still need to come out in order.

> This isn't completely trivial, because there it's not possible to associate each log message with a specific log category -- GetLog(FOO | BAR) will return a log object if either of the two categories are set. So we'd either need to attach a set of categories to each log message, give up the multi-category messages, or do something more complicated...

If we keep a list of messages and the log mask as the other part of the pair, it is very easy to keep as bot the "FOO" and "BAR" bits will be set in the 64 bit log mask.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128557/new/

https://reviews.llvm.org/D128557