[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

Mon Jun 27 03:08:06 PDT 2022

DavidSpickett added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp:51
+    gpr_w27_arm64, // ARM64_W27, 37)
+    gpr_w28_arm64, // ARM64_W28, 38)
+    LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
----------------
Is there a reason W29/W30/WZR are missing here?

================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp:88
+    gpr_sp_arm64,  // ARM64_SP, 81)
+    LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
+    LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
----------------
ARM64_ZR here? Though they're the same encoding in the instructions so it probably doesn't change much.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128221/new/

https://reviews.llvm.org/D128221