[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

[Emmmer S via Phabricator via lldb-commits]

Emmmer updated this revision to Diff 439955.
Emmmer marked an inline comment as done.
Emmmer added a comment.

This patch change:

- add `lldb/source/Plugins/Architecture/RISCV64`
- add `lldb/source/Plugins/Architecture/RISCV32`
- update `lldb/source/Utility/ArchSpec.cpp`
- remove `lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_riscv64`

> No DWARF numbers for the FPU regs?

I would like to add support for GPR first, after making sure they work well, FPU regs are a simple copy-paste.

> AArch64 linux build doesn't handle AArch32 mode, you'd need to use an AArch32 built binary for that.

Thanks for your suggestion, I split them out.

> and PAC means? (please add it to the comment)
> I don't see an implementation of this yet, not one that actually reads anything. Intentional? It'll just see 0 breakpoints I guess.

At first, I referenced the AArch64 code to add riscv64 support because their arch is similar, but I overlooked that riscv64 doesn't have a Debug reg yet, so it was a mistake on my part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128250/new/

https://reviews.llvm.org/D128250

Files:
  lldb/source/Plugins/Architecture/CMakeLists.txt
  lldb/source/Plugins/Architecture/RISCV32/ArchitectureRISCV32.cpp
  lldb/source/Plugins/Architecture/RISCV32/ArchitectureRISCV32.h
  lldb/source/Plugins/Architecture/RISCV32/CMakeLists.txt
  lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.cpp
  lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.h
  lldb/source/Plugins/Architecture/RISCV64/CMakeLists.txt
  lldb/source/Plugins/Process/Linux/CMakeLists.txt
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.h
  lldb/source/Plugins/Process/Utility/CMakeLists.txt
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_riscv64.cpp
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_riscv64.h
  lldb/source/Plugins/Process/Utility/RegisterInfos_riscv64.h
  lldb/source/Utility/ArchSpec.cpp
  lldb/source/Utility/RISCV64_DWARF_Registers.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128250.439955.patch
Type: text/x-patch
Size: 38164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220625/a8634afc/attachment-0001.bin>