[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Tue Jun 21 01:31:27 PDT 2022

DavidSpickett added a comment.

I'll give this a more thorough read later just one comment for now.

In the meantime, what's your plan for testing this config going forward? This patch would be fine as the first of a series but I'd like to see the follow ups that make it usable.

Will there be a build bot? You could at least enable building lldb on an existing riscv bot, while you iron out all the inevitable test suite issues.

================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.h:9
+
+#if defined(__riscv) || __riscv_xlen == 64
+
----------------
Should this be `&&`? I'm assuming that `__riscv` is also defined for riscv32.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128250/new/

https://reviews.llvm.org/D128250