[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

Jakob Johnson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 24 15:19:24 PDT 2022


jj10306 requested changes to this revision.
jj10306 added a comment.
This revision now requires changes to proceed.

will take a complete look over the weekend, but wanted to point out the conflict with @persona0220's diff asap



================
Comment at: lldb/include/lldb/Target/TraceCursor.h:93-98
-  /// Set the granularity to use in the \a TraceCursor::Next() method.
-  void SetGranularity(lldb::TraceInstructionControlFlowType granularity);
-
-  /// Set the "ignore errors" flag to use in the \a TraceCursor::Next() method.
-  void SetIgnoreErrors(bool ignore_errors);
-
----------------
@persona0220 did this in https://reviews.llvm.org/D128477 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128543/new/

https://reviews.llvm.org/D128543



More information about the lldb-commits mailing list