[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectLog.cpp:167
       buffer_size.Clear();
+      handler = eLogHandlerStream;
       log_options = 0;
----------------
labath wrote:
> mib wrote:
> > clayborg wrote:
> > > Do we want to define a "eLogHandlerDefault" which points to "eLogHandlerStream"?
> > I was hoping we could use a type alias for this, that marks `eLogHandlerStream` as `eLogHandlerDefault` but I couldn't find of a nice C++ way to do it :/ 
> Were you maybe looking for something like:
> ```
> enum {
>  foo_1,
>  foo_2,
>  ...,
>   foo_default = foo_47
> };
> ```
That could do :) ! I was thinking of doing :

```
enum {
foo_1,
foo_2,
...
};

using foo_default = foo_1;
```

But I don't think this works.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128323/new/

https://reviews.llvm.org/D128323