[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

Fri Jun 24 10:01:14 PDT 2022

JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

In D128321#3607935 <https://reviews.llvm.org/D128321#3607935>, @labath wrote:

> In D128321#3605592 <https://reviews.llvm.org/D128321#3605592>, @JDevlieghere wrote:
>
>> I also considered that, but that just delays the problem until I want to enable this handler for the always-on logging (as outlined in https://discourse.llvm.org/c/subprojects/lldb/8). I haven't really looked into where that logic would live, but the reproducers lived in Utility so I was expecting all of this to be there as well.
>
> I don't think that's a particularly big problem. Any code that's needed to enable always-on logging (to /a/ log handler) can stay in Utility. Only the code which actually enables it (and passes a specific log handler) needs to live outside. One way to do that would be to put something in the SystemInitializer class (like we did for reproducers). Another would be to use the shiny new global lldbinit file feature (which would allow site customization). :P

Right, not sure why I didn't think of that myself. Alright that covers all my concerns. Given that this was Greg's suggestion I'm assuming he's happy with this as well. Thank you both for the review!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128321/new/

https://reviews.llvm.org/D128321