[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This isn't turning out as clean as I had hoped it would, but I think it's a step in the right direction. Jonas, do you want to say anything about this?



================
Comment at: lldb/include/lldb/Expression/DWARFExpressionList.h:54
+  const DWARFExpression *
+  GetExpressionAtAddress(lldb::addr_t file_addr = 0) const;
+
----------------
calling GetExpressionAtAddress without an address seems weird. Maybe just have a separate GetAlwaysValidExpr getter or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125509/new/

https://reviews.llvm.org/D125509