[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D128480#3606598 <https://reviews.llvm.org/D128480#3606598>, @clayborg wrote:

> I don't have anything against this, though I still think the LogHandlers should use the Host layer by making the LogHandler objects into real LLDB plug-ins. But if everyone else feels otherwise, I won't object.

This patch is meant to be entirely orthogonal to that. I was still going to add (what I believe is a better) implementation of SystemLog. In D128321 <https://reviews.llvm.org/D128321> I said:

> But if we really want this to live in Host (and deal with the dependency issues later) I can implement a new Host::SystemLog variant that essentially does what the SystemLogHander is doing and implement the log handler in Host based on that.

So that's what I was alluding to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128480/new/

https://reviews.llvm.org/D128480