[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

Thu Jun 23 09:29:00 PDT 2022

mgorny added a comment.

In D127667#3603910 <https://reviews.llvm.org/D127667#3603910>, @labath wrote:

> Do we need the kill command to be asynchronous (return before the process actually dies) for anything. Could we just make it synchronous instead (call wait inside the process plugin, and return the wait result)?

Well, I have two concerns with that:

1. I have no clue about Windows or an environment to test it, so I wouldn't be able to update the Windows plugin code.
2. I'm a bit concerned about the Linux `PTRACE_EVENT_EXIT` handling. I mean, I suppose it's unlikely for something to go wrong there and cause us to hang but I'm not sure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127667/new/

https://reviews.llvm.org/D127667