[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

Thu Jun 23 01:05:02 PDT 2022

mstorsjo added a comment.

In D128268#3603931 <https://reviews.llvm.org/D128268#3603931>, @labath wrote:

>> As a separate path forward, one could also consider to stop returning
>> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications
>> for i386 files.
>
> I think that would be much more preferable. I think the current implementation GetModuleSpecifications is based on a misconception about what the multiple results of that function mean (a fat binary -- as you've discovered).
>
> We wouldn't want to return armv6-*-* (or armv7, v8, ...) for a file that claims it can be run on armv5. Elf files also return just a single result for i386 file.

Yep, that's probably a good path forward for the future - I was just weary of that possibly opening another huge can of worms. And regardless of that, I think the functional change of this patch, allowing considering various variations of triples that commonly occur on windows as compatible, is sensible on its own (such issues have caused unnecessary tweaking back and forth once or twice before too).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128268/new/

https://reviews.llvm.org/D128268