[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194
+  OutputWriterJSON(Stream &s, const TraceInstructionDumperOptions &options)
+      : m_s(s), m_options(options), m_j(/*IndentSize=*/m_s.AsRawOstream(),
+                                        options.pretty_print_json ? 2 : 0) {
+    m_j.arrayBegin();
----------------
jj10306 wrote:
> the inline comment should be next to the second parameter, right?
silly me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128316/new/

https://reviews.llvm.org/D128316