[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

[Martin Storsjö via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d123783957e: [lldb][windows] Fix crash on getting nested exception (authored by alvinhochun, committed by mstorsjo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128201/new/

https://reviews.llvm.org/D128201

Files:
  lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h


Index: lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
===================================================================
--- lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
+++ lldb/source/Plugins/Process/Windows/Common/ExceptionRecord.h
@@ -25,11 +25,17 @@
 class ExceptionRecord {
 public:
   ExceptionRecord(const EXCEPTION_RECORD &record, lldb::tid_t thread_id) {
+    // Notes about the `record.ExceptionRecord` field:
+    // In the past, some code tried to parse the nested exception with it, but
+    // in practice, that code just causes Access Violation. I suspect
+    // `ExceptionRecord` here actually points to the address space of the
+    // debuggee process. However, I did not manage to find any official or
+    // unofficial reference that clarifies this point. If anyone would like to
+    // reimplement this, please also keep in mind to check how this behaves when
+    // debugging a WOW64 process. I suspect you may have to use the explicit
+    // `EXCEPTION_RECORD32` and `EXCEPTION_RECORD64` structs.
     m_code = record.ExceptionCode;
     m_continuable = (record.ExceptionFlags == 0);
-    if (record.ExceptionRecord)
-      m_next_exception.reset(
-          new ExceptionRecord(*record.ExceptionRecord, thread_id));
     m_exception_addr = reinterpret_cast<lldb::addr_t>(record.ExceptionAddress);
     m_thread_id = thread_id;
     m_arguments.assign(record.ExceptionInformation,
@@ -39,27 +45,16 @@
   // MINIDUMP_EXCEPTIONs are almost identical to EXCEPTION_RECORDs.
   ExceptionRecord(const MINIDUMP_EXCEPTION &record, lldb::tid_t thread_id)
       : m_code(record.ExceptionCode), m_continuable(record.ExceptionFlags == 0),
-        m_next_exception(nullptr),
         m_exception_addr(static_cast<lldb::addr_t>(record.ExceptionAddress)),
         m_thread_id(thread_id),
         m_arguments(record.ExceptionInformation,
-                    record.ExceptionInformation + record.NumberParameters) {
-    // Set up link to nested exception.
-    if (record.ExceptionRecord) {
-      m_next_exception.reset(new ExceptionRecord(
-          *reinterpret_cast<const MINIDUMP_EXCEPTION *>(record.ExceptionRecord),
-          thread_id));
-    }
-  }
+                    record.ExceptionInformation + record.NumberParameters) {}
 
   virtual ~ExceptionRecord() {}
 
   DWORD
   GetExceptionCode() const { return m_code; }
   bool IsContinuable() const { return m_continuable; }
-  const ExceptionRecord *GetNextException() const {
-    return m_next_exception.get();
-  }
   lldb::addr_t GetExceptionAddress() const { return m_exception_addr; }
 
   lldb::tid_t GetThreadID() const { return m_thread_id; }
@@ -69,7 +64,6 @@
 private:
   DWORD m_code;
   bool m_continuable;
-  std::shared_ptr<ExceptionRecord> m_next_exception;
   lldb::addr_t m_exception_addr;
   lldb::tid_t m_thread_id;
   std::vector<ULONG_PTR> m_arguments;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128201.439010.patch
Type: text/x-patch
Size: 2888 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220622/d49dc0c8/attachment.bin>