[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment
Martin Storsjö via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 22 02:14:06 PDT 2022
mstorsjo added a comment.
In D128268#3601104 <https://reviews.llvm.org/D128268#3601104>, @DavidSpickett wrote:
> LGTM. I like the ifs the way I suggested but up to you, either way it's not the easiest logic to parse.
Oh, sorry, I forgot about that comment. Yes, that does indeed look even nicer, I'll try to add that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128268/new/
https://reviews.llvm.org/D128268
More information about the lldb-commits
mailing list