[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.

thanks Jim



================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:600
+          m_options.m_run_to_bkpt_args, target, result, &run_to_bkpt_ids, 
+          BreakpointName::Permissions::disablePerm);
+      if (!result.Succeeded()) {
----------------
from a quick read, it looks like this step will silently ignore bkpts it can't disable.

then a couple lines down the user might be told the breakpoints don't actually exist, which may not be true?


================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:636-637
+          if (bp_sp->IsEnabled()) {
+            if (loc_id == LLDB_INVALID_BREAK_ID)
+              any_enabled = true;
+            else {
----------------
this logic looks off, why is `any_enabled` set to true when the loc_id is `LLDB_INVALID_BREAK_ID`?


================
Comment at: lldb/test/API/commands/process/continue_to_bkpt/TestContinueToBkpts.py:2
+"""
+Test the "process continue -t" option.
+"""
----------------
s/-t/-b/


================
Comment at: lldb/test/API/commands/process/continue_to_bkpt/TestContinueToBkpts.py:16
+
+    mydir = TestBase.compute_mydir(__file__)
+
----------------
if you edit this file before committing, you can remove this line. `mydir` is now automatically computed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126513/new/

https://reviews.llvm.org/D126513