[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

David M. Lary via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 21 09:39:56 PDT 2022


dmlary added a comment.

Sent this via email, but doesn't look like it showed up here:

> I'm less concerned about the getter and the property and more about the underlying functionality. It doesn't look like it's being tested, and adding it to the SB API allows to change that.

Just to clarify, are you asking me to add a test for the underlying
functionality, `Section.GetLog2Align()`?  Or is the goal to add the
test at the SBSection level to ensure we detect if someone ever
changes the underlying api?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128069/new/

https://reviews.llvm.org/D128069



More information about the lldb-commits mailing list