[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 21 08:05:15 PDT 2022


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1967
+
+  if (multiprocess) {
+    for (auto &pid_ptr : m_debugged_processes)
----------------
without multiprocess extensions, we should never have more than one process, right? Could we just unconditionally use the multiprocess loop here (perhaps with an `assert(m_debugged_processes.size() == 1 || multiprocess)`) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128152/new/

https://reviews.llvm.org/D128152



More information about the lldb-commits mailing list