[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

Tue Jun 21 00:48:50 PDT 2022

DavidSpickett added inline comments.

================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13
+    EnumValues<"OptionEnumValues(g_abi_enums)">,
+    Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file name with extension. These versions are checked in sequence: exact, lowercase, exact with '.debug' suffix stripped, lowercase with '.debug' suffix stripped.">;
 }
----------------
alvinhochun wrote:
> DavidSpickett wrote:
> > What are the values accepted for this?
> It's the same enum as the setting `plugin.object-file.pe-coff.abi` added in D127048 - `default`, `msvc` and `gnu`.
Which makes sense but the user isn't always going to see both descriptions so I'd repeat that information here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127234/new/

https://reviews.llvm.org/D127234