[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139
+        if self.USE_SB_API:
+            traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath)
+            loadTraceError = lldb.SBError()
----------------
jj10306 wrote:
> wallace wrote:
> > jj10306 wrote:
> > > the single arg constructor is deprecated, update this to pass `resolve` flag
> > i don't think it's deprecated, but you should pass the resolve flag anyone
> You can find the deprecation warning in the comments here:
> https://lldb.llvm.org/cpp_reference/SBFileSpec_8cpp_source.html
TIL!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128107/new/

https://reviews.llvm.org/D128107