[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 20 07:08:52 PDT 2022


DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.

Any reason to `#if 0` this instead of just removing it and maybe adding a one line comment like "nested exceptions are not supported"? So that someone can git blame that and find this commit with the removal.

If this is not used at all this is academic, but what situation would it be describing if it did? Is it something like if you had an exception in a signal handler, that was handling an initial exception?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128201/new/

https://reviews.llvm.org/D128201



More information about the lldb-commits mailing list