[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 20 03:44:13 PDT 2022


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:697
 
+static int GetSignalForStopReason(const struct ThreadStopInfo &tid_stop_info) {
+  if (tid_stop_info.reason == eStopReasonException)
----------------
labath wrote:
> It seems this struct is only used in the lldb-server. Maybe we could make this a member function instead? Or move the signo field out of the union?
I would lean towards the latter, I guess. Lemme look about updating the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127193/new/

https://reviews.llvm.org/D127193



More information about the lldb-commits mailing list