[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I feel I should note that the llvm streams already have a buffered mode, and given the way things are implemented now (our log class writes the entire log message in one call, and the raw_ostream flushing the entire buffer whenever a message does not fit), I don't think this class has any advantages over using stream buffering (that's a very long-winded way of saying you're not going to get partial messages in either of the solutions). The only two differences I see are:

- one of them specifies the size, the other specifies the number of messages
- different behavior in case of races (in non-thread-safe mode). I'll write more on that elsewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128026/new/

https://reviews.llvm.org/D128026