[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Thanks for writing that! I'm sure many users will find it very useful.



================
Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2088
+The "liveness" of these settings is one way, from name to breakpoint.  
+If you use break modify to change an option that is also configured on a name 
+which that breakpoint has, the "break modify" command will override the setting 
----------------
Can we add some kind of quoting (backticks maybe) to this ?


================
Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2099-2102
+5) You can also use breakpoint names to hide breakpoints from normal breakpoint
+operations (list, delete and disable) by running "break name configure -N 
+<Name>" and specifying the --allow-{list,delete,disable} options and then adding 
+that name to a breakpoint.  This won't keep the breakpoint from being deleted 
----------------
Does it mean that giving a breakpoint a name will hide it by default to the `list,delete,disable` commands ?


================
Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2103-2106
+or disabled if you refer to it specifically by ID, but "break delete" and 
+"break disable" to delete or disable ALL breakpoints won't delete the ones 
+sharing the name, and "break list" won't show them.
+
----------------
This sentences is already very long. I'd either surround `to delete or disable ALL breakpoints` between commas or rephrase it like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127038/new/

https://reviews.llvm.org/D127038