[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

More generally, you can tell which elements of the exe_ctx you need to check in any given command by looking at requirements for the command which are passed into the constructor for the command.  Any entity that's required there, you don't need to check for, but otherwise, you do have to check.  "CommandObjectMemoryRead" has:

  eCommandRequiresTarget | eCommandProcessMustBePaused

so you should not need to check the target, but any references to the process, thread or frame in the exe_ctx must be checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127016/new/

https://reviews.llvm.org/D127016