[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 3 11:29:29 PDT 2022

jingham added inline comments.

Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:74-76
       // Pass in true for "no context switching".  The command that called us
       // should have set up the context appropriately, we shouldn't have to
       // redo that.
jingham wrote:
> clayborg wrote:
> > Is this comment out of date now? It mentions passing in "true"?
> No, that comment has to do with the Interpreter's ExecutionContext, not the history state.
Or rather, I think it was obsoleted a while ago.  What it's really explaining is why you don't need to call the version of HandleCommand that takes an override_context.  I think that was controlled by a bool at some point in the past.  I'll update the comment.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list