[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a reviewer: labath.
mstorsjo added a comment.

The implementation looks reasonable to me (I didn't investigate alternative ways of doing it but trust the reasoning that this is the most reasonable way of finding the pathname of an open handle with this filesystem driver).



================
Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:427
+
+  auto view_deleter = [](void *pMem) { ::UnmapViewOfFile(pMem); };
+  std::unique_ptr<void, decltype(view_deleter)> pMem(
----------------
Do you need a check against `NULL` here in `view_deleter`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126657/new/

https://reviews.llvm.org/D126657