[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

[Kaining Zhong via Phabricator via lldb-commits]

PRESIDENT810 updated this revision to Diff 432857.
PRESIDENT810 added a comment.

I have refactored my code so it should looks cleaner now, but I'm not sure how to add a test. It seems that adding a test for thin archive on macOS platforms can be not so straightforward. I see that in lldb/test/API/functionalities/archives/Makefile, the test suite is using libtool instead of ar to create archives on macOS platforms, and I don't know whether I can produce a thin archive with that. Also, ld on macOS platforms seems to be unable to identify thin archives (I'm using ld64.lld when testing my code locally).

I would really appreciate it if someone can provide some advice about how to implement such a test case here, thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126464/new/

https://reviews.llvm.org/D126464

Files:
  lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp
  lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126464.432857.patch
Type: text/x-patch
Size: 12438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220530/67a23cf9/attachment.bin>