[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

Don't have access to a macOS machine that can run the tests, so maybe someone should give this a spin before landing :)



================
Comment at: lldb/source/Interpreter/OptionValueProperties.cpp:257
   const OptionValueArray *array = value->GetAsArray();
-  if (array)
-    return array->GetArgs(args);
+  if (array) {
+    array->GetArgs(args);
----------------
The fix for the test is the change a few lines above. This change and the one below seem to have the same bug. Not sure if any properties are using this code at the moment, so technically this is an untested chance. I can drop if people care.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126057/new/

https://reviews.llvm.org/D126057