[Lldb-commits] [PATCH] D126021: [lldb/test] Fix PExpect.launch issue when disabling color support

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 19 14:46:04 PDT 2022

mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.

This patch should fix a bug in PExpect.launch that happened when color
support is not enabled.

In that case, we need to add the `--no-use-colors` flag to lldb's launch
argument list. However, previously, each character to the string was
appended separately to the `args` list. This patch solves that by adding
the whole string to the list.

This should fix the TestIOHandlerResize failure on GreenDragon.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>



Index: lldb/packages/Python/lldbsuite/test/lldbpexpect.py
--- lldb/packages/Python/lldbsuite/test/lldbpexpect.py
+++ lldb/packages/Python/lldbsuite/test/lldbpexpect.py
@@ -34,7 +34,7 @@
             args += run_under
         args += [lldbtest_config.lldbExec, '--no-lldbinit']
         if not use_colors:
-            args += '--no-use-colors'
+            args.append('--no-use-colors')
         for cmd in self.setUpCommands():
             if "use-color false" in cmd and use_colors:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126021.430810.patch
Type: text/x-patch
Size: 582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220519/97a2cee1/attachment.bin>

More information about the lldb-commits mailing list