[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 18 18:15:19 PDT 2022


JDevlieghere added inline comments.


================
Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50
+        self.do_test(80, ['Locating external symbol file for a.out...',
+                          'Loading Apple DWARF index for a.out...',
+                          'Parsing symbol table for dyld...'])
----------------
These two things are pretty Apple specific so maybe use the `skipUnlessDarwin` decorator? I think the locating symbol files will be printed on all platforms, but if we need to skip the test on Linux anyway that doesn't really buy us much to reduce the test coverage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124785/new/

https://reviews.llvm.org/D124785



More information about the lldb-commits mailing list