[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp:155
+      // add the symbol ObjectFile to this Module.
+      if (dsym_objfile_sp.get() && !module_sp->GetSymbolFileFileSpec()) {
+        module_sp->SetSymbolFileFileSpec(dsym_fspec);
----------------



================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:154-155
+          // Check to see if we have the file on the local filesystem.
+          if (!module_spec.GetFileSpec().GetPath().empty() &&
+              FileSystem::Instance().Exists(module_spec.GetFileSpec())) {
+            ModuleSpec exe_spec;
----------------
I assume an empty file spec wouldn't exist. Can this be simplified?


================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:165-169
+              if (log) {
+                LLDB_LOGF(log, "using original binary filepath %s for UUID %s",
+                          module_spec.GetFileSpec().GetPath().c_str(),
+                          uuid->GetAsString().c_str());
+              }
----------------
The macro checks if log is NULL.


================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:185-191
+              if (log) {
+                LLDB_LOGF(log,
+                          "using binary from shared cache for filepath %s for "
+                          "UUID %s",
+                          module_spec.GetFileSpec().GetPath().c_str(),
+                          uuid->GetAsString().c_str());
+              }
----------------



================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:203-206
               if (log) {
                 LLDB_LOGF(log, "plist bundle has exec path of %s for UUID %s",
                           path, uuid->GetAsString().c_str());
               }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125616/new/

https://reviews.llvm.org/D125616