[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

[Med Ismail Bennani via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex… (authored by mib).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125594/new/

https://reviews.llvm.org/D125594

Files:
  lldb/bindings/interface/SBCompileUnit.i
  lldb/include/lldb/API/SBCompileUnit.h
  lldb/source/API/SBCompileUnit.cpp
  lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py


Index: lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py
===================================================================
--- lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py
+++ lldb/test/API/python_api/compile_unit/TestCompileUnitAPI.py
@@ -37,7 +37,7 @@
         main_cu = sc_list.compile_units[0]
         self.assertTrue(main_cu.IsValid(), "Main executable CU is not valid")
 
-        self.assertEqual(main_cu.GetIndexForLineEntry(line_entry, True),
+        self.assertEqual(main_cu.FindLineEntryIndex(line_entry, True),
                          main_cu.FindLineEntryIndex(0, line_entry.GetLine(),
                                    line_entry.GetFileSpec(), True))
 
Index: lldb/source/API/SBCompileUnit.cpp
===================================================================
--- lldb/source/API/SBCompileUnit.cpp
+++ lldb/source/API/SBCompileUnit.cpp
@@ -77,8 +77,8 @@
   return sb_line_entry;
 }
 
-uint32_t SBCompileUnit::GetIndexForLineEntry(lldb::SBLineEntry &line_entry,
-                                             bool exact) const {
+uint32_t SBCompileUnit::FindLineEntryIndex(lldb::SBLineEntry &line_entry,
+                                           bool exact) const {
   LLDB_INSTRUMENT_VA(this, line_entry, exact);
 
   if (!m_opaque_ptr || !line_entry.IsValid())
Index: lldb/include/lldb/API/SBCompileUnit.h
===================================================================
--- lldb/include/lldb/API/SBCompileUnit.h
+++ lldb/include/lldb/API/SBCompileUnit.h
@@ -34,8 +34,8 @@
 
   lldb::SBLineEntry GetLineEntryAtIndex(uint32_t idx) const;
 
-  uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry,
-                                bool exact = false) const;
+  uint32_t FindLineEntryIndex(lldb::SBLineEntry &line_entry,
+                              bool exact = false) const;
 
   uint32_t FindLineEntryIndex(uint32_t start_idx, uint32_t line,
                               lldb::SBFileSpec *inline_file_spec) const;
Index: lldb/bindings/interface/SBCompileUnit.i
===================================================================
--- lldb/bindings/interface/SBCompileUnit.i
+++ lldb/bindings/interface/SBCompileUnit.i
@@ -79,9 +79,9 @@
 
      @return
         The index of the user-provided line entry. UINT32_MAX if the line entry
-        was not found in the compile unit.") GetIndexForLineEntry;
+        was not found in the compile unit.") FindLineEntryIndex;
     uint32_t
-    GetIndexForLineEntry (lldb::SBLineEntry &line_entry, bool exact = false) const;
+    FindLineEntryIndex (lldb::SBLineEntry &line_entry, bool exact = false) const;
 
     uint32_t
     FindLineEntryIndex (uint32_t start_idx,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125594.429399.patch
Type: text/x-patch
Size: 2675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220514/6c7f09cb/attachment-0001.bin>