[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 13 15:52:35 PDT 2022


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:1025-1027
-    except Exception as e:
-        result.PutCString("error: python exception: %s" % e)
-        return
----------------
mib wrote:
> What about printing the exception backtrace and exiting cleaning instead of crashing ?
What's the advantage? 

  - LLBB's embedded python interpreter is going to catch the exception and put the crash info in the command result object. 
  - When running directly under Python, the default exception handler is going to print the backtrace as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125589/new/

https://reviews.llvm.org/D125589



More information about the lldb-commits mailing list