[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

It might be a good idea to add a test for this. There seems to be a test already in this file:

  lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py

In fact looking at this test, it seems they specify the "SaveCoreStyle" via an option. As long as we are adding new APIs to SBProcess, we should probably add the "SaveCoreStyle style" as a parameter to the new SaveCore, this enum is already in the public header file (lldb-enumerations.h).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125325/new/

https://reviews.llvm.org/D125325