[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This needs a doctoring for the API and some test.



================
Comment at: lldb/source/API/SBCompileUnit.cpp:86
+  uint32_t index = UINT32_MAX;
+  if (m_opaque_ptr && line_entry.IsValid()) {
+
----------------
llvm would prefer an early return here.


================
Comment at: lldb/source/API/SBCompileUnit.cpp:94
+
+    if (!exact ||
+        (exact && !LineEntry::Compare(line_entry.ref(), found_line_entry)))
----------------
Why do you have to do this Compare?  You already passed exact to FindLineEntry, does FindLineEntry really return line entries that fail your Compare test when exact is passed in as true?  That doesn't seem right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125437/new/

https://reviews.llvm.org/D125437