[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

Levon Ter-Grigoryan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 11 00:51:01 PDT 2022


PatriosTheGreat marked 3 inline comments as done.
PatriosTheGreat added a comment.

Hi Greg.

Thanks for the review.
I fixed the feedback.
I forgot the default initialization of plugin_name parameter in SBProcess.i in previous version, but I assume it's still better to explicitly create a separate method.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125325/new/

https://reviews.llvm.org/D125325



More information about the lldb-commits mailing list