[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312
   BreakpointSP dyld_break;
-  if (m_rendezvous.IsValid()) {
+  if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) {
     break_addr = m_rendezvous.GetBreakAddress();
----------------
yinghuitan wrote:
> Since zero break address is considered invalid, maybe move `m_rendezvous.GetBreakAddress() != 0` check into `DYLDRendezvous::IsValid()` method? 
I wanted to be safe and not mess up anyone else that might be using m_rendezvous.IsValid() as it isn't super clear what IsValid() should return. So to be super safe and not affect any other code, I would prefer to leave it this way unless one of the original authors of this file has a different opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125253/new/

https://reviews.llvm.org/D125253