[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 29 14:51:08 PDT 2022


jasonmolenda added a comment.

In D124597#3483197 <https://reviews.llvm.org/D124597#3483197>, @clayborg wrote:

> I wonder if this will help optimized code debugging at all!? Good catch

It came up in a kernel debugging session iirc; it was the case of a function doing a noreturn call, and when you went up to that stack frame, the variable was in one register up through the noreturn call, and then it was in a different register after that noreturn -- so we would print the wrong register value. :/  It takes a bit to get this exact issue, but printing an incorrect value was a worst case failure mode.  The API test case I came up with will only print that the variable is unavailable, instead of the wrong value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124597/new/

https://reviews.llvm.org/D124597



More information about the lldb-commits mailing list